applications: nrf_desktop: enable zms for nrf54h20 DK target #18924

kapi-no · 2024-11-18T09:18:12Z

Enabled the ZMS file system for the nRF54H20 DK in the nRF Desktop application. All board targets with the MRAM technology now use ZMS by default.

Ref: NCSDK-30319

NordicBuilder · 2024-11-18T09:34:52Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

MarekPieta · 2024-11-18T09:52:55Z

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

@@ -203,7 +203,8 @@ nRF5340 Audio
 nRF Desktop
 -----------

-|no_changes_yet_note|
+* Updated all :ref:`zephyr:nrf54h20dk_nrf54h20` configurations to migrate from the NVS file system to the ZMS file system.


Please mention that it's for settings backend (a reflink to nRF Desktop's Settings loader module page could be useful here too). The application does not explicitly use these file systems, the file systems only act as a backend for settings.

A brief update of the nRF Desktop's Settings loader module page (https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/applications/nrf_desktop/doc/settings_loader.html) might be needed too

applications/nrf_desktop/src/modules/Kconfig.caf_settings_loader.default

peknis · 2024-11-18T12:40:53Z

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

@@ -203,7 +203,8 @@ nRF5340 Audio
 nRF Desktop
 -----------

-|no_changes_yet_note|
+* Updated the `nrf_desktop_settings_loader` to make the :ref:`Zephyr Memory Storage (ZMS) <zephyr:zms_api>` the default file system for all board targets that use the MRAM technology.


Suggested change

* Updated the `nrf_desktop_settings_loader` to make the :ref:`Zephyr Memory Storage (ZMS) <zephyr:zms_api>` the default file system for all board targets that use the MRAM technology.

* Updated the :ref:`nrf_desktop_settings_loader` to make the :ref:`Zephyr Memory Storage (ZMS) <zephyr:zms_api>` the default file system for all board targets that use the MRAM technology.

MarekPieta · 2024-11-18T12:38:03Z

applications/nrf_desktop/doc/settings_loader.rst

+* :ref:`Zephyr Memory Storage (ZMS) <zephyr:zms_api>` - see the following :kconfig:option:`CONFIG_SETTINGS_ZMS` Kconfig option for more details.
+* :ref:`Non-Volatile Storage (NVS) <zephyr:nvs_api>` - see the following :kconfig:option:`CONFIG_SETTINGS_NVS` Kconfig option for more details.
+
+ZMS is used for the devices with the RRAM or MRAM non-volatile memory that do not require explicit erase.
+Otherwise, the NVS is used.


I would simplify it a bit:

Suggested change

* :ref:`Zephyr Memory Storage (ZMS) <zephyr:zms_api>` - see the following :kconfig:option:`CONFIG_SETTINGS_ZMS` Kconfig option for more details.

* :ref:`Non-Volatile Storage (NVS) <zephyr:nvs_api>` - see the following :kconfig:option:`CONFIG_SETTINGS_NVS` Kconfig option for more details.

ZMS is used for the devices with the RRAM or MRAM non-volatile memory that do not require explicit erase.

Otherwise, the NVS is used.

* :ref:`Zephyr Memory Storage (ZMS) <zephyr:zms_api>` - used for the devices with non-volatile memory that does not require explicit erase (MRAM, RRAM).

* :ref:`Non-Volatile Storage (NVS) <zephyr:nvs_api>` - used for the devices with non-volatile memory that requires explicit erase (FLASH).

We should point to doc page instead of Kconfig option help for details

MarekPieta · 2024-11-18T12:40:16Z

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

+* Updated the `nrf_desktop_settings_loader` to make the :ref:`Zephyr Memory Storage (ZMS) <zephyr:zms_api>` the default file system for all board targets that use the MRAM technology.
+  As a result, all :ref:`zephyr:nrf54h20dk_nrf54h20` configurations were migrated from the NVS file system to the ZMS file system.


Suggested change

* Updated the `nrf_desktop_settings_loader` to make the :ref:`Zephyr Memory Storage (ZMS) <zephyr:zms_api>` the default file system for all board targets that use the MRAM technology.

As a result, all :ref:`zephyr:nrf54h20dk_nrf54h20` configurations were migrated from the NVS file system to the ZMS file system.

* Updated the :ref:`nrf_desktop_settings_loader` to make the :ref:`Zephyr Memory Storage (ZMS) <zephyr:zms_api>` the default settings backend for all board targets that use the MRAM technology.

As a result, all :ref:`zephyr:nrf54h20dk_nrf54h20` configurations were migrated from the NVS settings backend to the ZMS settings backend.

peknis

Approved with a nit.

applications/nrf_desktop/doc/settings_loader.rst

kapi-no · 2024-11-18T13:21:27Z

Fixed changelog conflict and addressed one minor comment

NordicBuilder · 2024-11-18T13:23:43Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: 939a4b2ec4831e68874d7fca1e0e12966ce359b2

more details

sdk-nrf:

PR head: 939a4b2ec4831e68874d7fca1e0e12966ce359b2
merge base: f067e19ca105c5a59bcbb82b3898b9deabc080de
target head (main): 2f3f82c9e338f9adc15138e1bb458e9fc8f59757
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (3)

applications
│  ├── nrf_desktop
│  │  ├── doc
│  │  │  │ settings_loader.rst
│  │  ├── src
│  │  │  ├── modules
│  │  │  │  │ Kconfig.caf_settings_loader.default
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst

Outputs:

Toolchain

Version: f51bdba1d9
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:f51bdba1d9_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 82
✅ Integration tests
- ✅ desktop52_verification

Disabled integration tests

- doc-internal
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_mosh
- test-fw-nrfconnect-nrf-iot_nrf_provisioning
- test-fw-nrfconnect-nrf-iot_positioning
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-ps
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread
- test-fw-nrfconnect-zigbee
- test-low-level
- test-sdk-audio
- test-sdk-dfu
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-sidewalk
- test-sdk-wifi

Note: This message is automatically posted and updated by the CI

divipillai

nit

applications/nrf_desktop/doc/settings_loader.rst

kapi-no · 2024-11-18T13:48:40Z

@nordicjm or @tejlmand, could you take a look as build system codeowners?

nordicjm

Kconfig is OK, some plural parts in documentation that are flipped

applications/nrf_desktop/doc/settings_loader.rst

Enabled the ZMS file system for the nRF54H20 DK in the nRF Desktop application. All board targets with the MRAM technology now use ZMS by default. Ref: NCSDK-30319 Signed-off-by: Kamil Piszczek <[email protected]>

kapi-no requested review from a team as code owners November 18, 2024 09:18

github-actions bot added the doc-required PR must not be merged without tech writer approval. label Nov 18, 2024

kapi-no requested review from MarekPieta and mkapala-nordic November 18, 2024 09:19

mkapala-nordic approved these changes Nov 18, 2024

View reviewed changes

divipillai reviewed Nov 18, 2024

View reviewed changes

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst Outdated Show resolved Hide resolved

MarekPieta requested changes Nov 18, 2024

View reviewed changes

kapi-no force-pushed the nrf_desktop_nrf54h20_zms branch from 68f8ea6 to 2db1525 Compare November 18, 2024 12:32

kapi-no requested a review from a team as a code owner November 18, 2024 12:32

kapi-no requested review from MarekPieta and divipillai November 18, 2024 12:32

peknis requested changes Nov 18, 2024

View reviewed changes

MarekPieta approved these changes Nov 18, 2024

View reviewed changes

kapi-no force-pushed the nrf_desktop_nrf54h20_zms branch from 2db1525 to 67d0cd5 Compare November 18, 2024 12:51

kapi-no requested review from peknis and MarekPieta November 18, 2024 12:51

MarekPieta approved these changes Nov 18, 2024

View reviewed changes

peknis approved these changes Nov 18, 2024

View reviewed changes

applications/nrf_desktop/doc/settings_loader.rst Outdated Show resolved Hide resolved

kapi-no force-pushed the nrf_desktop_nrf54h20_zms branch from 67d0cd5 to 687bf1a Compare November 18, 2024 13:20

kapi-no requested review from MarekPieta, peknis and mkapala-nordic November 18, 2024 13:22

peknis approved these changes Nov 18, 2024

View reviewed changes

MarekPieta approved these changes Nov 18, 2024

View reviewed changes

mkapala-nordic approved these changes Nov 18, 2024

View reviewed changes

divipillai approved these changes Nov 18, 2024

View reviewed changes

applications/nrf_desktop/doc/settings_loader.rst Outdated Show resolved Hide resolved

kapi-no force-pushed the nrf_desktop_nrf54h20_zms branch from 687bf1a to 6644f5a Compare November 18, 2024 13:47

kapi-no requested a review from divipillai November 18, 2024 13:48

divipillai approved these changes Nov 18, 2024

View reviewed changes

nordicjm reviewed Nov 18, 2024

View reviewed changes

applications/nrf_desktop/doc/settings_loader.rst Outdated Show resolved Hide resolved

applications/nrf_desktop/doc/settings_loader.rst Outdated Show resolved Hide resolved

kapi-no requested a review from nordicjm November 18, 2024 14:01

applications: nrf_desktop: enable zms for nrf54h20 DK target

939a4b2

Enabled the ZMS file system for the nRF54H20 DK in the nRF Desktop application. All board targets with the MRAM technology now use ZMS by default. Ref: NCSDK-30319 Signed-off-by: Kamil Piszczek <[email protected]>

kapi-no force-pushed the nrf_desktop_nrf54h20_zms branch from 6644f5a to 939a4b2 Compare November 18, 2024 14:01

kapi-no requested review from divipillai and peknis November 18, 2024 14:02

nordicjm approved these changes Nov 18, 2024

View reviewed changes

peknis approved these changes Nov 18, 2024

View reviewed changes

divipillai approved these changes Nov 18, 2024

View reviewed changes

rlubos merged commit b6c93e1 into nrfconnect:main Nov 18, 2024
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

applications: nrf_desktop: enable zms for nrf54h20 DK target #18924

applications: nrf_desktop: enable zms for nrf54h20 DK target #18924

kapi-no commented Nov 18, 2024

NordicBuilder commented Nov 18, 2024

MarekPieta Nov 18, 2024

MarekPieta Nov 18, 2024

peknis Nov 18, 2024

MarekPieta Nov 18, 2024 •

edited

Loading

MarekPieta Nov 18, 2024

peknis left a comment

kapi-no commented Nov 18, 2024

NordicBuilder commented Nov 18, 2024 •

edited

Loading

divipillai left a comment

kapi-no commented Nov 18, 2024

nordicjm left a comment

	* Updated the `nrf_desktop_settings_loader` to make the :ref:`Zephyr Memory Storage (ZMS) <zephyr:zms_api>` the default file system for all board targets that use the MRAM technology.
	* Updated the :ref:`nrf_desktop_settings_loader` to make the :ref:`Zephyr Memory Storage (ZMS) <zephyr:zms_api>` the default file system for all board targets that use the MRAM technology.

		* Updated the `nrf_desktop_settings_loader` to make the :ref:`Zephyr Memory Storage (ZMS) <zephyr:zms_api>` the default file system for all board targets that use the MRAM technology.
		As a result, all :ref:`zephyr:nrf54h20dk_nrf54h20` configurations were migrated from the NVS file system to the ZMS file system.

applications: nrf_desktop: enable zms for nrf54h20 DK target #18924

applications: nrf_desktop: enable zms for nrf54h20 DK target #18924

Conversation

kapi-no commented Nov 18, 2024

NordicBuilder commented Nov 18, 2024

MarekPieta Nov 18, 2024

Choose a reason for hiding this comment

MarekPieta Nov 18, 2024

Choose a reason for hiding this comment

peknis Nov 18, 2024

Choose a reason for hiding this comment

MarekPieta Nov 18, 2024 • edited Loading

Choose a reason for hiding this comment

MarekPieta Nov 18, 2024

Choose a reason for hiding this comment

peknis left a comment

Choose a reason for hiding this comment

kapi-no commented Nov 18, 2024

NordicBuilder commented Nov 18, 2024 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

divipillai left a comment

Choose a reason for hiding this comment

kapi-no commented Nov 18, 2024

nordicjm left a comment

Choose a reason for hiding this comment

MarekPieta Nov 18, 2024 •

edited

Loading

NordicBuilder commented Nov 18, 2024 •

edited

Loading