Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: cellular: nrf_cloud_rest_*: make credentials check optional #18822

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maxd-nordic
Copy link
Contributor

This patch makes it possible to build the nRF Cloud REST samples without checking the credentials. Jira: IRIS-9758

@maxd-nordic maxd-nordic requested a review from a team as a code owner November 12, 2024 15:23
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 12, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 12, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: 810d4bab36d11b26005fa8964e42ec76e17d3897

more details

sdk-nrf:

PR head: 810d4bab36d11b26005fa8964e42ec76e17d3897
merge base: 12bc79b87cd95a7155b610ccca4e2419065da211
target head (main): 12bc79b87cd95a7155b610ccca4e2419065da211
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3)
samples
│  ├── cellular
│  │  ├── nrf_cloud_rest_cell_location
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── nrf_cloud_rest_device_message
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── nrf_cloud_rest_fota
│  │  │  ├── src
│  │  │  │  │ main.c

Outputs:

Toolchain

Version: f51bdba1d9
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:f51bdba1d9_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ❌ Build twister
    • sdk-nrf test count: 218
  • ❌ Integration tests
    • ⚠️ test-fw-nrfconnect-fw-update
    • ⚠️ test-fw-nrfconnect-nrf-iot_cloud
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

Copy link
Contributor

@simensrostad simensrostad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason / usecase for removing the check?

samples/cellular/nrf_cloud_rest_cell_location/src/main.c Outdated Show resolved Hide resolved
samples/cellular/nrf_cloud_rest_device_message/src/main.c Outdated Show resolved Hide resolved
@maxd-nordic maxd-nordic force-pushed the nrf-cloud-rest-samples-wo-cert-check branch from 4a70e91 to ce78cbf Compare November 18, 2024 12:18
@maxd-nordic maxd-nordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 18, 2024
This patch makes it possible to build the nRF Cloud REST samples without
checking the credentials. Jira: IRIS-9758

Signed-off-by: Maximilian Deubel <[email protected]>
@maxd-nordic maxd-nordic force-pushed the nrf-cloud-rest-samples-wo-cert-check branch from ce78cbf to 810d4ba Compare November 18, 2024 16:15
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants