Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to event details from check-in notice #595

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

jb3
Copy link
Member

@jb3 jb3 commented Oct 12, 2024

Again a feature requested earlier today.

This hyperlinks the check-in notice so you can quickly browse event details before checking in.

image

@jb3
Copy link
Member Author

jb3 commented Oct 12, 2024

I've changed the contrast a little:

image

It does make it not as easily recognizable as a link, but it does have hover feedback & the old version wasn't a link at all so it's still an improvement.

If people really care I can switch to a button but I think this is fine.

@jerbzz
Copy link
Contributor

jerbzz commented Oct 13, 2024

I like this feature, I'd go back to the default link colour though

@jb3
Copy link
Member Author

jb3 commented Oct 13, 2024

I like this feature, I'd go back to the default link colour though

Sure, I'll swap it back :-)

@jb3
Copy link
Member Author

jb3 commented Oct 13, 2024

Commit was reverted in the force push 👍

@jb3 jb3 force-pushed the jb3/features/event-link branch 3 times, most recently from 32a3fe1 to 6043374 Compare October 17, 2024 21:11
@FreneticScribbler
Copy link
Member

The default link colour on an 'info' coloured box is too low contrast - even the revised version was a little low (why is the default a shade of grey, not a proper black, these days?)

Looking at it again, I'm tempted to override bootstrap's CSS to use a white/black font on the alerts instead of one with the theme colour so it's actually vaguely readable - ala the other places the theme colours are used, in buttons etc. "alert-light" is a crime!

@jb3
Copy link
Member Author

jb3 commented Oct 24, 2024

Have pulled in the changes locally, one method to I guess ensure contrast on the blue background is to just use a very different colour, I don't hate it being red.

image

@FreneticScribbler FreneticScribbler merged commit e5c7e24 into nottinghamtec:master Oct 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants