Skip to content

Commit

Permalink
Updating test and container build workflows (#21)
Browse files Browse the repository at this point in the history
* testing anchor defaults

* scope out matrix defaults

* embed anchors

* remove global defaults

* use anchors and add py 3.12

* update srl to 23.7.2

* fixing supported combinations

* added 2.15.5 for image build
  • Loading branch information
hellt authored Oct 27, 2023
1 parent 24a116d commit e0aeb96
Show file tree
Hide file tree
Showing 3 changed files with 77 additions and 31 deletions.
24 changes: 13 additions & 11 deletions .github/container-matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,23 @@
# a matrix list of variables used in the container build process
#
# python version are taken from ansible's support matrix - https://docs.ansible.com/ansible/latest/reference_appendices/release_and_maintenance.html#support-life
# ansible-core-image version is taken from https://github.com/orgs/srl-labs/packages?repo_name=ansible-core
include:
# 2.14.10
- ansible-core-image: "2.14.10:pypy3.10"
# 2.14.11
- ansible-core-image: "2.14.11:pypy3.10"
runs-on: "ubuntu-22.04"

- ansible-core-image: "2.14.10:py3.11"
- ansible-core-image: "2.14.11:py3.11"
runs-on: "ubuntu-22.04"
addional-tags: "latest"

# 2.15.4
# - base-image: "pypy:3.10-slim"
# ansible-core-version: "2.15.4"
# runs-on: "ubuntu-22.04"
# 2.15.5
- ansible-core-image: "2.15.5:pypy3.10"
runs-on: "ubuntu-22.04"

# - base-image: "python:3.11-slim"
# ansible-core-version: "2.15.4"
# runs-on: "ubuntu-22.04"
# addional-tags: "latest"
- ansible-core-image: "2.15.5:py3.11"
runs-on: "ubuntu-22.04"
addional-tags: "latest"

- ansible-core-image: "2.15.5:py3.12"
runs-on: "ubuntu-22.04"
82 changes: 63 additions & 19 deletions .github/matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,33 +5,77 @@
# a matrix list of variables used in testing
# kind of a manual way of creating a testing matrix with a flexibility of selecting permuatations
# support matrix for ansible control node - https://docs.ansible.com/ansible/latest/installation_guide/intro_installation.html#node-requirement-summary

include:
####################
# Python 3.8
- python-version: "3.8"
####################
- &latest-2_12
ansible-core-version: "2.12.10"
runs-on: "ubuntu-22.04"
- python-version: "3.8"
ansible-core-version: "2.13.8"
python-version: "3.8"

- &latest-2_13
ansible-core-version: "2.13.13"
runs-on: "ubuntu-22.04"
python-version: "3.8"

####################
# Python 3.9
- python-version: "3.9"
ansible-core-version: "2.12.10"
runs-on: "ubuntu-22.04"
- python-version: "3.9"
ansible-core-version: "2.13.8"
####################
- <<: *latest-2_12
python-version: "3.9"

- <<: *latest-2_13
python-version: "3.9"

- &latest-2_14
ansible-core-version: "2.14.11"
runs-on: "ubuntu-22.04"
- python-version: "3.9"
ansible-core-version: "2.14.3"
python-version: "3.9"

- &latest-2_15
ansible-core-version: "2.15.5"
runs-on: "ubuntu-22.04"
python-version: "3.9"

####################
# Python 3.10
- python-version: "3.9"
ansible-core-version: "2.12.10"
runs-on: "ubuntu-22.04"
- python-version: "3.9"
ansible-core-version: "2.13.8"
runs-on: "ubuntu-22.04"
- python-version: "3.9"
ansible-core-version: "2.14.3"
runs-on: "ubuntu-22.04"
####################

# removing 2_12 and 2_13 because TLS tests are failing
# this doesn't make the collection unusable with these versions
# when 23.10 comes out with TLS 1.3 we will remove these checks and bring back 2_12 and 2_13
# - <<: *latest-2_12
# python-version: "3.10"

# - <<: *latest-2_13
# python-version: "3.10"

- <<: *latest-2_14
python-version: "3.10"

- <<: *latest-2_15
python-version: "3.10"

####################
# Python 3.11
####################

# - <<: *latest-2_12
# python-version: "3.11"

# - <<: *latest-2_13
# python-version: "3.11"

- <<: *latest-2_14
python-version: "3.11"

- <<: *latest-2_15
python-version: "3.11"

####################
# Python 3.12
####################
- <<: *latest-2_15
python-version: "3.12"
2 changes: 1 addition & 1 deletion scripts/topo.clab.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ topology:
nodes:
srl:
kind: srl
image: ghcr.io/nokia/srlinux:${SRLINUX_VERSION:=23.3.2}
image: ghcr.io/nokia/srlinux:${SRLINUX_VERSION:=23.7.2}
# type and startup config are used to test Openconfig modules
type: ixr6
startup-config: oc.cfg

0 comments on commit e0aeb96

Please sign in to comment.