test_runner: error on mocking an already mocked date #55858
+10
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55849
Previously, the properties from the global
Date
, including the not-writableisMock
and[kMock]
values, would be copied if the globalDate
was already mocked. This became an issue because the mock setup would attempt overwrite these properties.Now,
ERR_INVALID_STATE
is thrown, asDate is already being mocked!
.Example
Before
After