Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: add openid-client #1072

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

panva
Copy link
Member

@panva panva commented Oct 15, 2024

adds openid-client

It covers the Web Cryptography API and Fetch API modules.

@panva
Copy link
Member Author

panva commented Oct 15, 2024

Hard Requirements

  • Module source code must be on Github.
  • Published versions must include a tag on Github
  • The test process must be executable with only commands
  • The tests pass on supported major release lines (skipped 18 because of its lack of webcrypto global)
  • The maintainers of the module remain responsive when there are problems
  • At least one module maintainer must be added to the lookup maintainers field

Soft Requirements

  • The module must be actively used by the community
  • The module must be heavily depended on
  • The module must cover unique portions of our API (WebCryptoAPI, fetch API)
  • ❓ The module fits into a key category (e.g. Testing, Streams, Monitoring, etc.)
  • The module is under the Node.js foundation Github org
  • The module is identified as an important module by a Node.js Working Group
    Procedure

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.76%. Comparing base (92761dd) to head (e50ffb9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1072   +/-   ##
=======================================
  Coverage   92.76%   92.76%           
=======================================
  Files          29       29           
  Lines        2197     2197           
=======================================
  Hits         2038     2038           
  Misses        159      159           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/lookup.json Outdated Show resolved Hide resolved
@richardlau
Copy link
Member

richardlau commented Oct 16, 2024

Let's see how this fares in the CI: https://ci.nodejs.org/job/citgm-smoker-pipeline/259/
Subbuilds:

@panva
Copy link
Member Author

panva commented Oct 16, 2024

hmm, i suspect chrome is not installed on the machines, the end2end tests use puppeteer-core (to orchestrate user interactions) and chrome-launcher to find the chrome executable... So we might not be able to add this to CITGM afterall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants