Add workflow to test packages #473
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
requested changes
Nov 11, 2024
.github/workflows/test_packages.yml
Outdated
Comment on lines
34
to
52
| - name: Test import sharktank | ||
| id: import_sharktank | ||
| run: | | ||
| python -c "import sharktank; print('Sanity check passed')" | ||
| - name: Test import shortfin | ||
| id: import_shortfin | ||
| run: | | ||
| python -c "import shortfin; print('Sanity check passed')" |
There was a problem hiding this comment.
Probably want to split this into multiple jobs:
- Test shortfin
- Test sharktank
- Test both together
Each package should be able to stand on its own (at least until we make one of them depend on the other)
For the combined case, we can run tests/workflows like https://github.com/nod-ai/SHARK-Platform/blob/main/.github/workflows/ci-shark-platform.yml too.
marbre
force-pushed
the
test-packages
branch
from
b3e8a59
to
1f163ab
Compare
marbre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.