Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gatsby build pipeline #196

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

janbrasna
Copy link

@janbrasna janbrasna commented Feb 28, 2024

  1. Replaces current CI workflow (broken) with newer build actions.
  2. Obsoletes old gh-pages deploy path writing to branch by instead publishing the build artifacts directly to the (existing) github-pages environment:
    • once working, old gh-pages branch can be removed as it's not used anymore;
    • the github-pages deployment exists from the old implicit runs, no need to create…
    • … however it will be most likely protected to only allow gh-pages to publish, needs to be changed to master in repo settings (or removed altogether) [docs]
    • no CNAME is needed since the value is configured in repo settings — should be still present from the legacy Pages so just needs checking. [docs]
  3. For now uses Node 14 as it won't build on 16/20, GH encourages to upgrade to at least to Node 16 so this might need looking into eventually, all the deps are rather old.
  4. Downgrades Gatsby and SASS back before dependabot broken the env in Bump http-cache-semantics, gatsby and gatsby-plugin-sharp in /web #193 and Bump node-sass from 4.13.1 to 7.0.0 in /web #156 💣 🙉
  5. Adds missing fbjs dep that should've been loaded by some react-dom deps however was missing 🤷
  6. Removes gh-pages dep (as publishing from local dev is not needed anymore), incl. the run commands.
  7. Removes some unnecessary files, updates the JSX content where URLs are hard-coded, adds Node compatibility to readme.

@janbrasna
Copy link
Author

janbrasna commented Feb 28, 2024

@noahsark769 You can see the workflow run details.

It's rather slow and emits loads of warnings. but seems to work ok otherwise. You probably know better if all the warnings are present the whole time locally too.

As this won't be run too often I don't care that much about output sizes, caches and 2-3mins build time as long as these legacy versions work, run and build;) so you can just forget about deploys and have them always published on master. 🚀

Being in ./web makes all steps unhappy looking for default locations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant