Skip to content

Commit

Permalink
Merge pull request #230 from nlesc-nano/qd_opt
Browse files Browse the repository at this point in the history
ENH: Add the ``qd.dissociate.qd_opt`` keyword
  • Loading branch information
BvB93 authored Jan 20, 2022
2 parents 40d6388 + af62c7a commit 76ecd01
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CAT/data_handling/validation_schemas.py
Original file line number Diff line number Diff line change
Expand Up @@ -775,6 +775,9 @@ def _get_crsjob() -> type:
),

Optional_("xyn_pre_opt", default=True): bool,

Optional_("qd_opt", default=False): bool,

})

#: Schema for validating the ``['optional']['qd']['optimize']`` block.
Expand Down
1 change: 1 addition & 0 deletions CAT/workflows/workflow_yaml.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ bde:
job2: [optional, qd, dissociate, job2]
s2: [optional, qd, dissociate, s2]
xyn_pre_opt: [optional, qd, dissociate, xyn_pre_opt]
qd_opt: [optional, qd, dissociate, qd_opt]

core_atom: [optional, qd, dissociate, core_atom]
lig_count: [optional, qd, dissociate, lig_count]
Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ This project adheres to `Semantic Versioning <http://semver.org/>`_.

0.10.4
******
* *placeholder*.
* Added the ``qd.dissociate.qd_opt`` keyword.
* Fix thermochemical properties not properly being set to ``nan`` for crashed jobs.


0.10.3
Expand Down
9 changes: 9 additions & 0 deletions docs/5_bde.rst
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,15 @@ Arguments
are marked as ``"vertice"``, the ones with ``8`` neighbours are marked as ``"edge"``
and the ones with ``10`` neighbours as ``"face"``.


.. attribute:: optional.qd.dissociate.qd_opt

:Parameter: * **Type** - :class:`bool`
* **Default value** – ``False``

Whether to optimize the quantum dot and |XYn| -dissociated quantum dot.


|
Arguments - Job Customization
Expand Down
1 change: 1 addition & 0 deletions tests/test_schemas.py
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,7 @@ def test_bde_schema() -> None:

'keep_files': True,
'xyn_pre_opt': True,
'qd_opt': False,
'job1': AMSJob,
's1': _bde_s1_default,
'job2': None,
Expand Down

0 comments on commit 76ecd01

Please sign in to comment.