fix(requests): preventConcurrentRequest along with staleTime (#486)

trackRequestResult no longer considers staleTime when skipping a request with status: fetching. Previously it was possible to get concurrent requests even if preventConcurrentRequest was set because all requests that were 'fetching' were also stale. Co-authored-by: Simon Hemåker <[email protected]>
ngneat · Sep 18, 2023 · b5abab0 · b5abab0
1 parent 8d30ccb
commit b5abab0
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 2 deletions.
diff --git a/packages/requests/src/lib/requests-result.spec.ts b/packages/requests/src/lib/requests-result.spec.ts
@@ -605,6 +605,37 @@ describe('requests result', () => {
     expect(reqSpy).toHaveBeenCalledTimes(2);
   });
 
+  it('should prevent concurrent requests when stale time is set', () => {
+    jest.useFakeTimers();
+
+    const { state, config } = createState(withEntities<Todo>());
+
+    const store = new Store({ state, config, name: 'todos' });
+    const reqSpy = jest.fn();
+
+    function getTodos() {
+      return timer(1000).pipe(
+        map(() => [createTodo(1)]),
+        tap(() => reqSpy()),
+        tap((todos) => store.update(setEntities(todos))),
+        trackRequestResult(['todos'], { staleTime: 900_000, preventConcurrentRequest: true })
+      );
+    }
+
+    getTodos().subscribe();
+    getTodos().subscribe();
+
+    jest.runAllTimers();
+
+    expect(reqSpy).toHaveBeenCalledTimes(1);
+
+    getTodos().subscribe();
+
+    jest.runAllTimers();
+
+    expect(reqSpy).toHaveBeenCalledTimes(1);
+  });
+
   it('should request when staleTime pass', () => {
     jest.useFakeTimers();
 

diff --git a/packages/requests/src/lib/requests-result.ts b/packages/requests/src/lib/requests-result.ts
@@ -214,8 +214,7 @@ export function trackRequestResult<TData>(
         if (
           result.fetchStatus === 'fetching' &&
           preventConcurrentRequest &&
-          !options?.skipCache &&
-          !stale
+          !options?.skipCache
         ) {
           return getRequestResult(key).pipe(
             filter((requestResult) => requestResult.fetchStatus === 'idle'),