Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate the PLY parser #1053

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Reinstate the PLY parser #1053

merged 2 commits into from
Sep 26, 2024

Conversation

fredludlow
Copy link
Collaborator

This seems to work... (TS conversion of the latest PLYLoader from the three.js project and adaptation into the NGL parser infrastructure)

The parser/ply example is active again.

Fixes #1049

@fredludlow
Copy link
Collaborator Author

@ppillot - If you have time / would like to review please do so - if I hear nothing in a week or so I'll merge and try and remember how to release :)

Copy link
Collaborator

@ppillot ppillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well!
("Representation / Label" is also fixed with this PR)

For the release, npm version minor should do the trick

@fredludlow fredludlow merged commit 69a039b into nglviewer:master Sep 26, 2024
2 checks passed
@fredludlow fredludlow deleted the ply-parser branch October 9, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loading ply file error
2 participants