Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/test: Fix missing parameter to nxt_log_alert() in nxt_base64_test() #1481

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

ac000
Copy link
Member

@ac000 ac000 commented Oct 26, 2024

nxt_log_alert() was missing the nxt_str_t parameter as required by the %V format specifier.

This was found with the Unit clang-ast plugin.

@ac000 ac000 requested a review from hongzhidao October 26, 2024 17:57
@ac000 ac000 marked this pull request as ready for review October 26, 2024 17:57
@ac000
Copy link
Member Author

ac000 commented Oct 27, 2024

Add a Fixes tag

$ git range-diff 2bd455bc...1506a14c
1:  2bd455bc ! 1:  1506a14c src/test: Fix missing parameter to nxt_log_alert() in nxt_base64_test()
    @@ Commit message
     
         This was found with the Unit clang-ast plugin.
     
    +    Fixes: 7bf625394 ("Custom implementation of Base64 decoding function.")
         Signed-off-by: Andrew Clayton <[email protected]>
     
      ## src/test/nxt_base64_test.c ##

Copy link
Contributor

@hongzhidao hongzhidao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

nxt_log_alert() was missing the nxt_str_t parameter as required by the
%V format specifier.

This was found with the Unit clang-ast plugin.

Fixes: 7bf6253 ("Custom implementation of Base64 decoding function.")
Signed-off-by: Andrew Clayton <[email protected]>
@ac000
Copy link
Member Author

ac000 commented Oct 29, 2024

Rebase with master

$ git range-diff 1506a14c...9f6f4866
-:  -------- > 1:  85f21b7c Use nxt_nitems() instead of sizeof() for strings (arrays)
1:  1506a14c = 2:  9f6f4866 src/test: Fix missing parameter to nxt_log_alert() in nxt_base64_test()

@ac000 ac000 merged commit 9f6f486 into nginx:master Oct 29, 2024
22 of 23 checks passed
@ac000 ac000 deleted the test-fix branch October 29, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants