chore(deps): bump tailwind-merge version #3657
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: a4ec0c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Caution Review failedThe pull request is closed. WalkthroughThis change introduces a patch for the Changes
Assessment against linked issues
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
Files selected for processing (4)
- .changeset/grumpy-mayflies-rhyme.md (1 hunks)
- packages/core/theme/package.json (1 hunks)
- packages/core/theme/src/utils/cn.ts (1 hunks)
- packages/core/theme/src/utils/tw-merge-config.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- .changeset/grumpy-mayflies-rhyme.md
Additional comments not posted (3)
packages/core/theme/src/utils/tw-merge-config.ts (1)
3-3: Consider the implications of removing explicit type annotations.The removal of the explicit type
Partial<Config>fromtwMergeConfigmay increase flexibility by relying on TypeScript's type inference. However, this can potentially reduce type safety if the inferred type does not match the expected structure. Ensure that this change aligns with your project's type safety requirements.packages/core/theme/src/utils/cn.ts (1)
13-13: Verify compatibility with the new configuration structure.The change to use
{extend: twMergeConfig}inextendTailwindMergelikely aims to provide more flexible configuration handling. Ensure that theextendkey is correctly processed by theextendTailwindMergefunction and that it aligns with the expected configuration structure.packages/core/theme/package.json (1)
60-60: Verify compatibility of the updatedtailwind-mergedependency.The update to
tailwind-mergeversion^2.5.2likely includes new features and bug fixes. Ensure that this version is compatible with your current codebase and does not introduce any breaking changes, especially in how class names are merged.
wingkwong
requested review from
ryo-manba
and removed request for
jrgarciadev
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
.changeset/grumpy-mayflies-rhyme.md (1)
5-5: Enhance the changeset message with more details.While the current message references the issue number, it would be beneficial to include more information about the changes and their impact. Consider adding:
- The specific version of
tailwind-mergebeing upgraded to.- A brief explanation of why this upgrade is necessary.
- Any potential changes in behavior that users should be aware of.
Here's a suggested revision:
bump `tailwind-merge` version from ^1.14.0 to ^2.5.2 (#3614) This upgrade addresses issues with newer Tailwind CSS features and improves class merging behavior. Users may notice changes in how certain classes are merged, particularly with new default configurations like `text-wrap`.This additional context will help users understand the implications of the update when they read the changelog.
* chore(deps): bump tailwind-merge versions * chore(theme): adopt latest extendTailwindMerge * chore(changeset): add changeset * chore(changeset): change to minor * Update .changeset/grumpy-mayflies-rhyme.md --------- Co-authored-by: Junior Garcia <[email protected]>
Closes #3614
📝 Description
tailwind-mergeis still using v1. Upgrade to v2.⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit
tailwind-mergedependency to enhance styling capabilities and performance.@nextui-org/themepackage to improve overall theme integration.