Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show focus ring when table row is focused in read mode #1303

Conversation

jguddas
Copy link
Contributor

@jguddas jguddas commented Aug 6, 2023

A table is still focusable in read mode and should still show a focus ring.

Steps to reproduce:

  1. Open https://storybook.nextui.org/iframe.html?args=&id=components-table--static&viewMode=story
  2. Press tab
  3. Press leftleftleftleft

Fixed:

simplescreenrecorder-2023-08-06_21.00.42.mp4

@vercel
Copy link

vercel bot commented Aug 6, 2023

@jguddas is attempting to deploy a commit to the NextUI Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot
Copy link

changeset-bot bot commented Aug 6, 2023

🦋 Changeset detected

Latest commit: 5f86ac9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@nextui-org/table Patch
@nextui-org/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jrgarciadev jrgarciadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge thanks @jguddas Sorry the delay

@jrgarciadev jrgarciadev merged commit 290cce1 into nextui-org:main Aug 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants