Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass secrets to release job #1676

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Pass secrets to release job #1676

merged 1 commit into from
Nov 12, 2024

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Nov 12, 2024

Description of proposed changes

The release workflow needs to specify secrets: inherit so that the release job in the called workflow can access secrets to do its thing.

Related issue(s)

Fixes #1674

Checklist

  • Automated checks pass N/A
  • Check if you need to add a changelog message
  • Check if you need to add tests
  • Check if you need to update docs
  • Post-merge: next release happens successfully (ref)

The release workflow needs to specify `secrets: inherit` so that the
release job in the called workflow can access secrets to do its thing.
@victorlin victorlin self-assigned this Nov 12, 2024
@victorlin victorlin merged commit 96f077b into master Nov 12, 2024
26 checks passed
@victorlin victorlin deleted the victorlin/fix-release branch November 12, 2024 23:10
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.29%. Comparing base (84d65d3) to head (802fc37).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1676   +/-   ##
=======================================
  Coverage   72.29%   72.29%           
=======================================
  Files          79       79           
  Lines        8276     8276           
  Branches     1691     1691           
=======================================
  Hits         5983     5983           
  Misses       2008     2008           
  Partials      285      285           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in release workflow: it doesn't actually release anymore
1 participant