Removing secondary exceptions from console #5513
Draft
+21
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jorgee
commented
Nov 15, 2024
jorgee
commented
- Unknown errors before session abort have been moved from log.error to log.debug to do not print them in the console.
- When session is cancelled and later aborted, do not call notifyError in abort (duplicate error notifications)
Signed-off-by: jorgee <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: jorgee <[email protected]>
pditommaso
reviewed
Nov 15, 2024
| @@ -95,7 +95,7 @@ class DataflowHelper { | |||
| @Override | |||
| boolean onException(final DataflowProcessor processor, final Throwable t) { | |||
| final e = t instanceof InvocationTargetException ? t.cause : t | |||
| OperatorImpl.log.error("@unknown", e) | |||
| OperatorImpl.log.debug("@unknown", e) | |||
There was a problem hiding this comment.
Would not make more sense to rely only on session.abort to report this error?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.