Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate process shell block #5508

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

bentsherman
Copy link
Member

Based on some recent internal discussions. The original purpose of the shell block was to help distinguish between Nextflow and Bash variables in the process script. Since the VS Code extension now provides both syntax highlighting and error checking for variable names, the shell block isn't needed as much and can be phased out to promote consistent code.

I didn't bother to add a warning in the code because I will add one in the language server, but we can add one here if you want.

@bentsherman bentsherman requested a review from a team as a code owner November 14, 2024 18:00
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit c60db9c
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/673643d357da5500085b21a1

Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Ben Sherman <[email protected]>
@pditommaso
Copy link
Member

It would make sense to add a deprecation warning (and a warning to disable it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants