Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Rxjava to coroutines #2 #4446

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Migrate Rxjava to coroutines #2 #4446

wants to merge 9 commits into from

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Nov 14, 2024

Resolve #4411

  • Use only one API for setting password of a room.

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Signed-off-by: sowjanyakch <[email protected]>
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings94153
Errors13288

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7474
Internationalization33
Malicious code vulnerability33
Performance55
Security11
Total108108

Lint increased!

@sowjanyakch sowjanyakch self-assigned this Nov 14, 2024
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Nov 14, 2024
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4446-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@sowjanyakch
Copy link
Contributor Author

The earlier implementation of AlertDialog for weak password does not work as expected. Fixing AlertDialog is out of scope of this PR. This PR only focuses on migrating to coroutines from Rxjava.

@sowjanyakch sowjanyakch marked this pull request as ready for review November 14, 2024 08:43
@sowjanyakch sowjanyakch changed the title Coroutine 2 Migrate Rxjava to coroutines #2 Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate some RxJava to coroutines #2
1 participant