Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert CallActivity to kotlin #3205

Merged
merged 4 commits into from
Jul 27, 2023
Merged

convert CallActivity to kotlin #3205

merged 4 commits into from
Jul 27, 2023

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Jul 25, 2023 •
edited by AndyScherzinger
Loading

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi self-assigned this Jul 25, 2023
@mahibi mahibi added this to the 17.1.0 milestone Jul 25, 2023
@mahibi mahibi added the 3. to review Waiting for reviews label Jul 25, 2023
@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9394
Errors00

SpotBugs

CategoryBaseNew
Correctness99
Dodgy code163127
Internationalization55
Malicious code vulnerability33
Performance98
Security22
Total191154

Lint increased!

mahibi and others added 4 commits July 27, 2023 12:01
@mahibi @AndyScherzinger
convert CallActivity to kotlin
56bb57d 
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi @AndyScherzinger
convert CallActivity to kotlin
c079435 
Signed-off-by: Marcel Hibbe <[email protected]>
@AndyScherzinger
Fix some magic numbers, bump score
7152683 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
remove unused resource
6841845 
Signed-off-by: Andy Scherzinger <[email protected]>
@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3205-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi
Copy link
Collaborator Author

mahibi commented Jul 27, 2023

thanks @AndyScherzinger

@mahibi mahibi merged commit 6a0605b into master Jul 27, 2023
12 of 15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the convertCallActivityToKotlin branch July 27, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees

@mahibi mahibi

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
17.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mahibi @AndyScherzinger