add disposable

however i was not able to see onDestroy being executed. anyway, disposables won't be necessary when coroutine is used. also: remove a useless outdated log line Signed-off-by: Marcel Hibbe <[email protected]>
nextcloud · Nov 14, 2024 · dc54718 · dc54718
1 parent fefb99e
commit dc54718
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt b/app/src/main/java/com/nextcloud/talk/chat/ChatActivity.kt
@@ -2440,7 +2440,7 @@ class ChatActivity :
         currentlyPlayedVoiceMessage?.let { stopMediaPlayer(it) } // FIXME, mediaplayer can sometimes be null here
 
         adapter = null
-        Log.d(TAG, "inConversation was set to false!")
+        disposables.dispose()
     }
 
     private fun joinRoomWithPassword() {
@@ -2505,7 +2505,7 @@ class ChatActivity :
                 ?.observeOn(AndroidSchedulers.mainThread())
                 ?.subscribe(object : Observer<SignalingSettingsOverall> {
                     override fun onSubscribe(d: Disposable) {
-                        // unused atm
+                        disposables.add(d)
                     }
 
                     override fun onNext(signalingSettingsOverall: SignalingSettingsOverall) {