fix: Handle copy of folders containing live photos #49293
+61
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to recursively look for live photos in the folder, and then handle them as usual. Signed-off-by: Louis Chemineau <[email protected]>
kesselb
reviewed
Nov 14, 2024
Comment on lines
+195
to
+196
| $targetNode = $targetNode->get($sourceChild->getName()); | ||
| $this->handleCopyRecursive($event, $sourceChild, $targetNode); |
There was a problem hiding this comment.
Suggested change
| $targetNode = $targetNode->get($sourceChild->getName()); | |
| $this->handleCopyRecursive($event, $sourceChild, $targetNode); | |
| $targetChild = $targetNode->get($sourceChild->getName()); | |
| $this->handleCopyRecursive($event, $sourceChild, $targetChild); |
Otherwise, it fails for the second file.
kesselb
reviewed
Nov 14, 2024
Comment on lines
133
to
134
| * @param NodeCopiedEvent $event | ||
| * @param Node $peerFile |
There was a problem hiding this comment.
Suggested change
| * @param NodeCopiedEvent $event | |
| * @param Node $peerFile |
|
getDirectoryListing may return a listing like
Loop:
It would be nice to skip the copy process for a.mov and a.jpg for the second execution if that's possible without making the whole logic much more complex. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to recursively look for live photos in the folder, and then handle them as usual.
Might fix #49289