Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't require nodePort to template if none is specified #606

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Don't require nodePort to template if none is specified #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/nextcloud/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: nextcloud
version: 5.5.5
version: 5.5.6
appVersion: 29.0.6
description: A file sharing server that puts the control and security of your own data back into your hands.
keywords:
Expand Down
6 changes: 3 additions & 3 deletions charts/nextcloud/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ spec:
targetPort: {{ .Values.nextcloud.containerPort }}
protocol: TCP
name: http
{{- if (eq .Values.service.type "NodePort") }}
nodePort: {{ .Values.service.nodePort | default "" }}
{{- with .Values.service.nodePort }}
nodePort: {{ . }}
{{- end }}
selector:
app.kubernetes.io/name: {{ include "nextcloud.name" . }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/component: app
app.kubernetes.io/component: app
2 changes: 1 addition & 1 deletion charts/nextcloud/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ service:
type: ClusterIP
port: 8080
loadBalancerIP: ""
nodePort: nil
nodePort:
annotations: {}
## Insert your annotations such as below
# test/test: pumuckel
Expand Down