Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md - add section about two or more replicas with traefik #492

Closed
wants to merge 3 commits into from

Conversation

supermario18b
Copy link

@supermario18b supermario18b commented Dec 3, 2023

Pull Request

Description of the change

It was explained how to create a traefik ingressRoute Resource that uses sticky sessions

Benefits

Users can login when more nextcloud replicas are used

Possible drawbacks

I don't see any

Applicable issues

when more replicas

two or more replicas with traefik

Signed-off-by: supermario18b <[email protected]>
charts/nextcloud/README.md Outdated Show resolved Hide resolved
@jessebot jessebot changed the title Update README.md Update README.md - add section about two or more replicas with traefik Dec 5, 2023
@jessebot
Copy link
Collaborator

jessebot commented Dec 5, 2023

awesome, thanks for this! I've made the tiniest suggestion and then this can merged :)

@wrenix
Copy link
Collaborator

wrenix commented Dec 8, 2023

Maybe we should use annotations and write docu for multiple ingress-controller:

Your docu is very traefik specifiy and would be maybe replaced with gateway-api and standard over multiple ingress-controller:
https://gateway-api.sigs.k8s.io/implementations/
Current state for session policy: https://gateway-api.sigs.k8s.io/geps/gep-1619/

@jessebot
Copy link
Collaborator

jessebot commented Dec 15, 2023

@wrenix I feel like having a full ingress section of the docs would be nice, and we can certainly approach that later if you'd like, but I think getting this merged is still a good idea in the meantime. In particular, I've seen a lot of hype around the new gateway api (I'm also hyped!), but haven't actually played with it yet. I'd be down for some docs on it as well.

@wrenix
Copy link
Collaborator

wrenix commented Aug 11, 2024

Sorry, i believe you have miss understand me.
The Idea is, that we should minimize the documentation of not using CustomResources from ingress-controller (ingress-operator in this case) if the ingress-controller could work also with annotations on the ingress-manifest.

The Idea/Reason: An annotation is just a value which has to be set in that helm-chart that is much easier then to deploy an additional manifest (or to put another/not-necessary manifest in that helm-chart. But when the Gateway API is more distributed (as a new standard) then i like the idea to put a "not-necessary Manifest" in a helm-chart. <- this small unimportant sentence was to much present i my last comment)

@wrenix
Copy link
Collaborator

wrenix commented Oct 22, 2024

@jessebot could we close this PR now? After merge of #621

Or @supermario18b do you like to improve there the traefik section?

@wrenix wrenix requested a review from jessebot October 22, 2024 15:33
@supermario18b
Copy link
Author

supermario18b commented Oct 22, 2024

Or supermario18b do you like to improve there the traefik section?
@wrenix you can close the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants