-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create CONTRIBUTING.md #469
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JesseBot <[email protected]>
Signed-off-by: JesseBot <[email protected]>
jessebot
commented
Nov 13, 2023
Signed-off-by: JesseBot <[email protected]>
provokateurin
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, I just have some nitpicks
Co-authored-by: Kate <[email protected]> Signed-off-by: JesseBot <[email protected]>
Co-authored-by: Kate <[email protected]> Signed-off-by: JesseBot <[email protected]>
Co-authored-by: Kate <[email protected]> Signed-off-by: JesseBot <[email protected]>
thank you! :) |
Can you squash? |
oop, missed this, but yeah, the default strategy is squash and merge for me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
This adds a little contributing doc that we can update over time as we need.
Benefits
This should show up on the side panel of the repo, and makes it easier to link. Some users familiar with CONTRIBUTING.md docs will check for this before submitting a PR.
Possible drawbacks
None that I can think of
Applicable issues
none that I can remember
Additional information
none that I can think of
Checklist
Chart.yaml
according to semver.