Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bitnami/postgresql to 12.12.10 #467

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

archer-321
Copy link
Contributor

Pull Request

Description of the change

This PR updates the postgresql dependency from 12.11.2 to 12.12.10 as requested by this comment. Notably, it doesn't update to 13.2.5, as major version PostgreSQL updates tend to require manual intervention, and this would require the chart to be bumped to 5.x.

Benefits

This update includes various upstream changes to the postgresql dependency.

Possible drawbacks

This is not the latest version available. However, as described above, updating to 13.x would require a major version increase.

Applicable issues

N/A

Additional information

Steps to test (copied from #​446; using minikube):

  • Start a fresh cluster:
    minikube start -p nextcloud
  • Clone this PR's branch:
    mkdir nextcloud-helm && cd nextcloud-helm && git init \
    && git pull --depth=1 https://github.com/nextcloud/helm.git refs/pull/446/merge:refs/heads/main
    
  • Download the dependencies:
    cd charts/nextcloud && helm dep build
  • Create test-values.yaml:
    cat << EOF > test-values.yaml
    ingress:
      enabled: true
    externalDatabase:
      enabled: true
      type: postgresql
      host: albacore-postgresql-0:5432
      user: nextcloud
      database: nextcloud
      existingSecret:
        enabled: false
        secretName: postgres-creds
        passwordKey: user
    internalDatabase:
      enabled: false
    postgresql:
      enabled: true
      global:
        postgresql:
          auth:
            existingSecret: postgres-creds
            secretKeys:
              adminPasswordKey: admin
              userPasswordKey: user
              replicationPasswordKey: replication
    EOF
    
  • Create the secret:
    kubectl create secret generic postgres-creds --from-literal=user=foo --from-literal=replication=bar --from-literal=admin=baz --from-literal=db-username=nextcloud
  • Install this PR's chart:
    helm install -f test-values.yaml albacore .
  • Test the Nextcloud deployment.

Checklist

This commit updates the postgresql dependency to version 12.12.10. This
is the latest 12.x version currently available, and while 13.x is
technically available, this would likely require bumping the nextcloud
chart version to 5.x, as PostgreSQL major version updates require manual
intervention in most cases (especially with the expected limited scope
of the embedded chart).

Signed-off-by: Archer <[email protected]>
@jessebot jessebot self-requested a review November 13, 2023 13:03
@jessebot
Copy link
Collaborator

thanks, @archer-321, this gets us a lot closer to a current version :)

@jessebot jessebot merged commit 9ba93c7 into nextcloud:main Nov 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants