Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Redis, Postgresql, and Maridb to latest OCI Bitnami helm chart versions #420

Merged
merged 4 commits into from
Aug 19, 2023

Conversation

jessebot
Copy link
Collaborator

@jessebot jessebot commented Jul 24, 2023

Pull Request

Description of the change

Benefits

This puts us at the latest versions, so we aren't deploying a major version out of date. I haven't checked, but there may also be security patches that we would benefit from here.

Possible drawbacks

⚠️ Users already having deployed the chart using our bundled postgresql bitnami sub-chart will need to upgrade their databases to stay current according to Bitnami's postgresql chart README . Official upgrade instructions can be found here.

Applicable issues

Don't think there's any right now.

Additional information

Bumping major version of chart to account for major version bump of subcharts, but we can also do a minor version here as all of these are optional? Open to feedback on which number to bump.

Upgrade of Redis should not incur any extra work according to their README docs here.

MariaDB doesn't have a major appVersion bump so there's no upgrade instructions listed.

Checklist

- Upgrades all bitnami subcharts to the latest major versions at time of commit
- Updates to new preferred OCI-based container registry

Signed-off-by: JesseBot <[email protected]>
@@ -1,6 +1,6 @@
apiVersion: v2
name: nextcloud
version: 3.5.19
version: 4.0.0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 4.0.0
version: 3.6.0

This can also be 3.6.0 if we only want to bump a minor version of this chart.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say that since the subchart updates are major, I'd make it a major release.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me! I'll keep it as is. I've also added some basic docs for upgrading nextcloud itself to #419 and in this one, after I test the upgrade of postgres on my end, I'll add some notes for that as well if anything goes weird and then we can probably merge this after #419.

@jessebot jessebot self-assigned this Jul 24, 2023
@jessebot jessebot marked this pull request as ready for review July 24, 2023 14:25
Copy link
Collaborator

@tvories tvories left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nerocide
Copy link

nerocide commented Aug 6, 2023

As new bitnami charts now support arm64, my cluster would really benefit this merge.

Thank you for your work @jessebot

@jessebot
Copy link
Collaborator Author

jessebot commented Aug 6, 2023

Sorry for the delay! Longhorn failed for me recently (long story, but they pushed up a breaking change that had cascading effects and took out my whole home lab and backups D:) I've been rebuilding my home lab (and recovering backups), and should probably be done in another day. In the meantime, if others have tested upgrade this, I'm happy to see it merged 💙

@ibcht
Copy link
Contributor

ibcht commented Aug 9, 2023

This version installs seamlessly on my RPi4, with prepackaged mariadb. Not an upgrade though, as this looks like the first ARM64 compatible release, I only proceed to a fresh install.

@nerocide
Copy link

nerocide commented Aug 17, 2023

Just tried a fresh install on 4*bananapi CM4(arm64) with external postgres db, works perfectly👍

@jessebot
Copy link
Collaborator Author

@provokateurin I still haven't tested the upgrade, but since two others have tested fresh installs, do we want to merge this anyway? Unfortunately my homelab is still out of commission due to some other issues in my current stack (dealing with some issues lower in the stack with secrets management), so it'll probably be at least another few days till I can start testing nextcloud via helm specifically again.

We could just make sure the release notes have a link to the docs for upgrades for postgresql and to please report any other steps you had to do directly to us so we can inform others? I feel bad not merging this :<

@provokateurin
Copy link
Member

Sounds like a good plan

@jessebot jessebot merged commit 7ee7cf1 into main Aug 19, 2023
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the upgrade-sub-charts branch August 19, 2023 14:18
raynay-r pushed a commit to raynay-r/nextcloud-helm that referenced this pull request Apr 16, 2024
…t versions (nextcloud#420)

* Upgrade redis, postgresql, and maridb sub charts to latest

- Upgrades all bitnami subcharts to the latest major versions at time of commit
- Updates to new preferred OCI-based container registry

Signed-off-by: JesseBot <[email protected]>

* update Chart.lock file for subchart updates

Signed-off-by: jessebot <[email protected]>

---------

Signed-off-by: JesseBot <[email protected]>
Signed-off-by: jessebot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants