Cancel hydration

[camilasan]

#6914

• could the same file trigger hydration twice?
  

  desktop/src/gui/folder.cpp

  Line 1521 in 40ad6a2

  void Folder::slotHydrationStarts()

• this cancel sync logic might be broken

• you can have a the same file, but different parts of the file (data) getting hydrated

• is there a way to know the status of the hydration jobs?
  

  desktop/src/libsync/vfs/cfapi/vfs_cfapi.cpp

  Line 465 in 40ad6a2

  auto job = new HydrationJob(this);

It is hard to reproduce but this is more or less the steps:

• free up space in folder
• the client will make the files virtual again (0 byte)
• this action triggers the sync engine
• VFS and sync engine are then both running when it shouldn't

https://learn.microsoft.com/en-us/windows/win32/fileio/opportunistic-locks
https://learn.microsoft.com/en-us/windows/win32/api/cfapi/nf-cfapi-cfupdateplaceholder
https://learn.microsoft.com/en-us/windows/win32/api/cfapi/nf-cfapi-cfopenfilewithoplock

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-6936-8915cca965caba4b8da2ec215e781dbfef73be44-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarcloud]

Quality Gate failed

Failed conditions
1 Security Hotspot
32.8% Coverage on New Code (required ≥ 80%)
C Maintainability Rating on New Code (required ≥ A)
106 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint