-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NcActions): submenus #6209
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Design team told me some time ago that "back" should not be used, but rather the name of the parent option :) |
This was a direct request from @jancborchardt. Make sure we get his approval before changing that behaviour please :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, waiting for design decision
Nice job standardising this! Agree that the word "back" works best in this case. "set reminder" sounds like another action, while all the button is doing is literally bringing us back. I agree with @ShGKme point That said, I think this UI should only be a mobile fallback and we should have proper cascading menus like everybody else. It's way more intuitive to hover or tab through options than having to dive in and dive back out. Examples |
☑️ Resolves
Add submenu feature:
NcActionButton
'sis-menu
is now not only for an icon, but actually to handle a specific menu#submenu:NAME
slot is uses to pass a specific submenuTakes into account:
To discus:
submenu
vsmenu
name for slotis-menu
because it's already called like a boolean flag🖼️ Screenshots
Docs
In action
🏁 Checklist
next
requested with a Vue 3 upgrade