Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(next-example): add webauthn support w/ unstorage adapter #9963

Merged
merged 51 commits into from
May 11, 2024
Merged

chore(next-example): add webauthn support w/ unstorage adapter #9963

merged 51 commits into from
May 11, 2024

Conversation

ndom91
Copy link
Member

@ndom91 ndom91 commented Feb 8, 2024 •
edited
Loading

☕️ Reasoning

  • Add Passkey provider and @auth/unstorage-adapter to our apps/example/nextjs app.
  • Uses in-memory unstorage adapter, so data is deleted every deploy
    • That means that logins won't survive that long, but for a demo where folks login once (register) and then maybe logout / log back in a few times to test, I think this is totally fine.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

@vercel Vercel
Copy link

vercel bot commented Feb 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2024 1:45pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview May 11, 2024 1:45pm
nextra-docs ⬜️ Ignored (Inspect) Visit Preview May 11, 2024 1:45pm
proxy ⬜️ Ignored (Inspect) Visit Preview May 11, 2024 1:45pm

@github-actions github-actions bot added providers core Refers to `@auth/core` examples labels Feb 8, 2024
@ndom91 ndom91 marked this pull request as ready for review February 8, 2024 16:32
@ndom91
Copy link
Member Author

ndom91 commented Feb 8, 2024

Lol

image

balazsorban44
balazsorban44 previously requested changes Feb 8, 2024
View reviewed changes
apps/examples/nextjs/app/client-example/page.tsx Outdated Show resolved Hide resolved
apps/examples/nextjs/auth.ts Outdated Show resolved Hide resolved
apps/examples/nextjs/auth.ts Outdated Show resolved Hide resolved
apps/examples/nextjs/package.json Outdated Show resolved Hide resolved
packages/core/src/providers/webauthn.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the providers label Feb 8, 2024
@ndom91 ndom91 marked this pull request as draft February 8, 2024 21:59
@ndom91
Copy link
Member Author

ndom91 commented Feb 8, 2024 •
edited
Loading

Status update - still trying to use the advanced initialization to apply the adapter when trying to login with webauthn, but not with any of the oauth providers. Therefore we would avoid saving any session / user / account data into our database from oauth providers.

See last 2 commits (1, 2) for latest updates in regard to this

@github-actions github-actions bot removed the core Refers to `@auth/core` label May 10, 2024
@ndom91
Merge branch 'ndom91/nextjs-example-app-webauthn-db' of ssh://github.…
1a2a471 
…com/nextauthjs/next-auth into ndom91/nextjs-example-app-webauthn-db
@ndom91
Revert "Merge branch 'ndom91/nextjs-example-app-webauthn-db' of ssh:/…
ffeeee0 
…/github.com/nextauthjs/next-auth into ndom91/nextjs-example-app-webauthn-db"

This reverts commit 1a2a471, reversing
changes made to 42ca2bb.
@github-actions github-actions bot added the core Refers to `@auth/core` label May 10, 2024
@github-actions github-actions bot removed the core Refers to `@auth/core` label May 10, 2024
@ndom91 ndom91 merged commit 90c5738 into main May 11, 2024
9 of 10 checks passed
@ndom91 ndom91 deleted the ndom91/nextjs-example-app-webauthn-db branch May 11, 2024 13:45
hillac pushed a commit to hillac/next-auth that referenced this pull request Jun 19, 2024
@ndom91 @balazsorban44 @hillac
chore(next-example): add webauthn support w/ unstorage adapter (nexta…
12de7dc 
…uthjs#9963)

Co-authored-by: Balázs Orbán <[email protected]>
k3k8 pushed a commit to k3k8/next-auth that referenced this pull request Aug 1, 2024
@ndom91 @balazsorban44 @k3k8
chore(next-example): add webauthn support w/ unstorage adapter (nexta…
6bdbe77 
…uthjs#9963)

Co-authored-by: Balázs Orbán <[email protected]>
JipSterk pushed a commit to JipSterk/next-auth that referenced this pull request Aug 27, 2024
@ndom91 @balazsorban44 @JipSterk
chore(next-example): add webauthn support w/ unstorage adapter (nexta…
e8c7506 
…uthjs#9963)

Co-authored-by: Balázs Orbán <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThangHuuVu ThangHuuVu ThangHuuVu approved these changes

@balazsorban44 balazsorban44 balazsorban44 left review comments

@ubbe-xyz ubbe-xyz Awaiting requested review from ubbe-xyz ubbe-xyz is a code owner

Assignees
No one assigned
Labels
examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndom91 @balazsorban44 @ThangHuuVu