fix(ts): update AppRouteHandlerFn type to handle null response from middleware handler
#10050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@ajstars1 is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
|
Hmm interesting. @balazsorban44 it looks like Next.js itself just types this as PR which updated it last with some comments about why, etc.: vercel/next.js@f47c409#diff-66b976b1650819b48a11d6d16d984057aa95192edcd52e936fbeec386fc9c8eb |
ndom91
changed the title
AppRouteHandlerFn type to handle null response from middleware handler
|
still under review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
In NextAuth Function in Middleware type null does not contain in overload
Allow Null Return Value: The AppRouteHandlerFnContext type now includes null as a valid return value. This addresses the error: No overload matches this call : " Type 'null' is not assignable to type 'void | Response | Promise<void | Response>'"
🧢 Checklist
🎫 Affected issues
Fixed: #10047
📌 Resources