Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I had problem when using specific cookie to check and change the magento design package.
When people visit my site using a mobile device they will see a link "View desktop version", when they click that link I set a cookie
USE_FULL_SITE=1
then check and change the design package. In desktop version they will see a link "View mobile version" but when they click that link and I setUSE_FULL_SITE=0
, varnish return the same page.This PR add ability to add custom cookie key to the varnish hash, I created a configuration field in Admin > System > Configurations > Turpentine > Caching Options > Cookie-based Caching > Cookie Keys
I think people who use cookie to check and display/hide popup will have the same issue
Please consider to merge.
Thanks a lot,
Phu