Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom cookie hash #1316

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

Custom cookie hash #1316

wants to merge 3 commits into from

Conversation

hmphu
Copy link
Contributor

@hmphu hmphu commented Nov 18, 2016

Hi,

I had problem when using specific cookie to check and change the magento design package.

When people visit my site using a mobile device they will see a link "View desktop version", when they click that link I set a cookie USE_FULL_SITE=1 then check and change the design package. In desktop version they will see a link "View mobile version" but when they click that link and I set USE_FULL_SITE=0, varnish return the same page.

This PR add ability to add custom cookie key to the varnish hash, I created a configuration field in Admin > System > Configurations > Turpentine > Caching Options > Cookie-based Caching > Cookie Keys

I think people who use cookie to check and display/hide popup will have the same issue

Please consider to merge.

Thanks a lot,
Phu

@jeroenvermeulen
Copy link
Contributor

Looks good (did not test it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants