This repository has been archived by the owner on Jun 30, 2023. It is now read-only.
feat(ChildProcessStream): capture exit code on exit #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I somehow can't run the tests locally though/ |
|
I ran the tests, but for some reason I can't make it work ? |
|
do you mean , the test fails? |
justinmk
reviewed
Jul 1, 2022
|
Should be all good now. |
justinmk
reviewed
Jul 1, 2022
justinmk
reviewed
Jul 1, 2022
justinmk
reviewed
Jul 1, 2022
|
So, this does not work (again), and this time I really don't know why. |
justinmk
reviewed
Jul 1, 2022
| end) | ||
|
|
||
| it("can can capture signal", function() | ||
| session:close "kill" |
There was a problem hiding this comment.
This test does not pass for now, but it was needed in the exit code test.
|
Related/duplicate: #44 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here.
cc @justinmk