Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pageserver: enable virtual_file_io_mode=direct in CI by default #9716

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

yliang412
Copy link
Contributor

@yliang412 yliang412 commented Nov 11, 2024

Closes #9713

Problem

We have virtual_file_io_mode config, but we don't set it in CI. We should enable virtual_file_io_mode=direct for both regression tests and benchmarks.

Summary of changes

Config handling are done in the same way as what we did for virtual_file_io_engine.

  • Unit test setting are done through NEON_PAGESERVER_IOMODE, if not set, use virtual_file_io_mode=direct.
  • Set PAGESERVER_VIRTUAL_FILE_IO_MODE: direct in regression tests and benchmarks
  • For deployment that does not have virtual_file_io_mode config set, still use buffered io.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@yliang412 yliang412 added the run-extra-build-macos When placed on a PR, tells the CI to run a build on macOS. No unit tests are run, though. label Nov 11, 2024
Copy link

github-actions bot commented Nov 11, 2024

5418 tests run: 5169 passed, 6 failed, 243 skipped (full report)


Failures on Postgres 17

Failures on Postgres 16

Failures on Postgres 15

Failures on Postgres 14

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_pageserver_compaction_smoke[release-pg14] or test_tx_abort_with_many_relations[release-pg14] or test_pageserver_compaction_smoke[release-pg15] or test_pageserver_compaction_smoke[release-pg16] or test_timeline_archival_chaos[release-pg16] or test_tx_abort_with_many_relations[release-pg17]"

Test coverage report is not available

The comment gets automatically updated with the latest test results
d94a349 at 2024-11-14T20:15:42.331Z :recycle:

@yliang412 yliang412 marked this pull request as ready for review November 11, 2024 18:42
@yliang412 yliang412 requested a review from a team as a code owner November 11, 2024 18:42
@bayandin bayandin added the run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label label Nov 11, 2024
@bayandin
Copy link
Member

Added run-benchmarks label, to run benchmarks on next commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label run-extra-build-macos When placed on a PR, tells the CI to run a build on macOS. No unit tests are run, though.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pageserver: enable direct io for delta + image layer reads by default in regression tests and benchmark
2 participants