Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: remove separate check-build-tools-image workflow #9708

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bayandin
Copy link
Member

Problem

We call check-build-tools-image twice for each workflow whenever we use it, along with build-build-tools-image, once as a workflow itself, and the second time from build-build-tools-image. This is not necessary.

Summary of changes

  • Inline check-build-tools-image into build-build-tools-image
  • Remove separate check-build-tools-image workflow

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@bayandin bayandin requested a review from a team November 10, 2024 22:27
Copy link

github-actions bot commented Nov 10, 2024

5435 tests run: 5199 passed, 0 failed, 236 skipped (full report)


Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 31.8% (7892 of 24837 functions)
  • lines: 49.4% (62455 of 126362 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
a59dca0 at 2024-11-14T20:34:04.355Z :recycle:

@bayandin bayandin force-pushed the bayandin/remove-separate-check-build branch from 461b682 to a59dca0 Compare November 14, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant