experimental support for pg_anon #9706
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luist18
force-pushed
the
luist18/postgresql_anonymizer-experiments
branch
from
75b83d2
to
f54250b
Compare
github-actions
bot
removed
the
approved-for-ci-run
Closed
Signed-off-by: Luís Tavares <[email protected]>
5589 tests run: 5367 passed, 0 failed, 222 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
d202885 at 2024-11-11T13:55:05.996Z :recycle: |
luist18
force-pushed
the
luist18/postgresql_anonymizer-experiments
branch
from
f54250b
to
d9da270
Compare
|
@luist18 You don't need to use it, CI works for your's PRs straight away |
luist18
force-pushed
the
luist18/postgresql_anonymizer-experiments
branch
from
9446c2e
to
43a4b9e
Compare
luist18
force-pushed
the
luist18/postgresql_anonymizer-experiments
branch
3 times, most recently
from
fc14d32
to
f76582f
Compare
luist18
force-pushed
the
luist18/postgresql_anonymizer-experiments
branch
from
f76582f
to
4845f4f
Compare
luist18
force-pushed
the
luist18/postgresql_anonymizer-experiments
branch
from
e91a3fb
to
d202885
Compare
bayandin
reviewed
Nov 11, 2024
| # This is an experimental extension, never got to real production. | ||
| # !Do not remove! It can be present in shared_preload_libraries and compute will fail to start if library is not found. | ||
| ENV PATH="/usr/local/pgsql/bin/:$PATH" | ||
| RUN wget https://github.com/luist18/postgresql_anonymizer/archive/refs/heads/add-guc-hook.tar.gz -O pg_anon.tar.gz && \ |
There was a problem hiding this comment.
Just a note, that this should be moved to neondatabase-labs/neondatabase before merging (and preferably tagged / used from a commit hash)
Comment on lines
+1074
to
+1078
| echo 'trusted = true' >> /usr/local/pgsql/share/extension/anon.control && \ | ||
| find /usr/local/pgsql -type f | sed 's|^/usr/local/pgsql/||' > /after.txt &&\ | ||
| mkdir -p /extensions/anon && cp /usr/local/pgsql/share/extension/anon.control /extensions/anon && \ | ||
| sort -o /before.txt /before.txt && sort -o /after.txt /after.txt && \ | ||
| comm -13 /before.txt /after.txt | tar --directory=/usr/local/pgsql --zstd -cf /extensions/anon.tar.zst -T - |
There was a problem hiding this comment.
These 4 lines are not necessary (they were added to make anon a "custom" extension, which lives in a separate repo; here, it's a no-op); we can remove them.
Suggested change
| echo 'trusted = true' >> /usr/local/pgsql/share/extension/anon.control && \ | |
| find /usr/local/pgsql -type f | sed 's|^/usr/local/pgsql/||' > /after.txt &&\ | |
| mkdir -p /extensions/anon && cp /usr/local/pgsql/share/extension/anon.control /extensions/anon && \ | |
| sort -o /before.txt /before.txt && sort -o /after.txt /after.txt && \ | |
| comm -13 /before.txt /after.txt | tar --directory=/usr/local/pgsql --zstd -cf /extensions/anon.tar.zst -T - | |
| echo 'trusted = true' >> /usr/local/pgsql/share/extension/anon.control |
| RUN case "${PG_VERSION}" in "v17") \ | ||
| echo "v17 extensions are not supported yet. Quit" && exit 0;; \ | ||
| esac && \ | ||
| patch -p1 </ext-src/pg_anon.patch |
There was a problem hiding this comment.
We probably can delete the patch as well
|
@bayandin thank you for the review. I want to get the image tag to create a small internal POC. This is not supposed to be merged any time soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Summary of changes
Checklist before requesting a review
Checklist before merging