Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow archived timelines to be detached or reparented #9578

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Oct 29, 2024

Disallow a request for timeline ancestor detach if either the to be detached timeline, or any of the to be reparented timelines are offloaded or archived.

In theory we could support timelines that are archived but not offloaded, but archived timelines are at the risk of being offloaded, so we treat them like offloaded timelines. As for offloaded timelines, any code to "support" them would amount to unoffloading them, at which point we can just demand to have the timelines be unarchived.

Part of #8088

@arpad-m arpad-m requested a review from a team as a code owner October 29, 2024 23:58
@arpad-m arpad-m requested a review from jcsp October 29, 2024 23:58
Copy link

5328 tests run: 5106 passed, 0 failed, 222 skipped (full report)


Flaky tests (1)

Postgres 17

Code coverage* (full report)

  • functions: 31.5% (7758 of 24659 functions)
  • lines: 49.0% (61005 of 124563 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
3b96d57 at 2024-10-30T00:53:58.364Z :recycle:

@arpad-m arpad-m requested a review from skyzh October 30, 2024 14:42
@arpad-m arpad-m merged commit d0a02f3 into main Oct 30, 2024
86 checks passed
@arpad-m arpad-m deleted the arpad/offloaded_detach_ancestor branch October 30, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants