Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pageserver): handle lsn lease requests for unnormalized lsns #9137

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

yliang412
Copy link
Contributor

@yliang412 yliang412 commented Sep 24, 2024

Fixes #9098.

Problem

See #9098 (comment).

Related

A similar problem happened with branch creation, which was discussed here and fixed by #2529.

Summary of changes

  • Normalize the lsn on pageserver side upon lsn lease request, stores the normalized LSN.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@yliang412 yliang412 marked this pull request as ready for review September 24, 2024 23:28
@yliang412 yliang412 requested a review from a team as a code owner September 24, 2024 23:28
@yliang412 yliang412 requested a review from jcsp September 24, 2024 23:28
Copy link

github-actions bot commented Sep 24, 2024

4986 tests run: 4822 passed, 0 failed, 164 skipped (full report)


Flaky tests (5)

Postgres 17

Postgres 16

Postgres 14

Code coverage* (full report)

  • functions: 32.2% (7478 of 23255 functions)
  • lines: 50.0% (60245 of 120558 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
59e252e at 2024-09-25T02:16:18.721Z :recycle:

@yliang412 yliang412 enabled auto-merge (squash) September 25, 2024 14:39
@yliang412 yliang412 merged commit d447f49 into main Sep 25, 2024
79 checks passed
@yliang412 yliang412 deleted the yuchen/fix-test_readonly_node_gc branch September 25, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_readonly_node_gc failure
2 participants