-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dump backtrace if a core dump is called just "core" #9125
Conversation
If this works, a backtrace should appear in the compute log of the |
eb9e80a
to
97ee498
Compare
5039 tests run: 4881 passed, 0 failed, 158 skipped (full report)Flaky tests (6)Postgres 17
Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
d9111d0 at 2024-09-27T09:48:28.999Z :recycle: |
a64f715
to
6279c02
Compare
Ok, I now see a stacktrace in the compute log on x64 tests, e.g: https://neon-github-public-dev.s3.amazonaws.com/reports/pr-9125/11019165404/index.html#behaviors/b1a8273437954620fa374b796ffaacdd/449cc866dbb1dc47/?attachment=9d9a072d64577a52. But not on arm64 test runs. I guess we have configured those runners differently? In any case, this PR seems good to go, so I'll merge as soon as I get an approval. |
I hope this lets us capture backtraces in CI. At least it makes it work on my laptop, which is valuable even if we need to do more for CI. See issue #2800.
So that compute_ctl can use it to print backtrace on core dumps See issue #2800.
6279c02
to
438d9e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that's cool!
But not on arm64 test runs. I guess we have configured those runners differently?
cc @cicdteam regarding runners setup
438d9e7
to
d9111d0
Compare
I hope this lets us capture backtraces in CI. At least it makes it work on my laptop, which is valuable even if we need to do more for CI. See issue #2800.
I hope this lets us capture backtraces in CI. At least it makes it work on my laptop, which is valuable even if we need to do more for CI. See issue #2800.
So that compute_ctl can use it to print backtrace on core dumps See issue #2800.
I hope this lets us capture backtraces in CI. At least it makes it work on my laptop, which is valuable even if we need to do more for CI.
Fixes #2800.