Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump backtrace if a core dump is called just "core" #9125

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

hlinnaka
Copy link
Contributor

I hope this lets us capture backtraces in CI. At least it makes it work on my laptop, which is valuable even if we need to do more for CI.

Fixes #2800.

@hlinnaka
Copy link
Contributor Author

hlinnaka commented Sep 24, 2024

If this works, a backtrace should appear in the compute log of the test_endpoint_crash[debug-pg16-trigger_segfault] test.

@hlinnaka hlinnaka force-pushed the collect-regression-test-core-dump branch from eb9e80a to 97ee498 Compare September 24, 2024 14:20
Copy link

github-actions bot commented Sep 24, 2024

5039 tests run: 4881 passed, 0 failed, 158 skipped (full report)


Flaky tests (6)

Postgres 17

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 32.0% (7498 of 23402 functions)
  • lines: 50.0% (60540 of 120968 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d9111d0 at 2024-09-27T09:48:28.999Z :recycle:

@hlinnaka hlinnaka force-pushed the collect-regression-test-core-dump branch from a64f715 to 6279c02 Compare September 24, 2024 17:47
@hlinnaka
Copy link
Contributor Author

hlinnaka commented Sep 24, 2024

Ok, I now see a stacktrace in the compute log on x64 tests, e.g: https://neon-github-public-dev.s3.amazonaws.com/reports/pr-9125/11019165404/index.html#behaviors/b1a8273437954620fa374b796ffaacdd/449cc866dbb1dc47/?attachment=9d9a072d64577a52.

But not on arm64 test runs. I guess we have configured those runners differently?

In any case, this PR seems good to go, so I'll merge as soon as I get an approval.

hlinnaka added a commit that referenced this pull request Sep 24, 2024
I hope this lets us capture backtraces in CI. At least it makes it
work on my laptop, which is valuable even if we need to do more for
CI.

See issue #2800.
hlinnaka added a commit that referenced this pull request Sep 24, 2024
So that compute_ctl can use it to print backtrace on core dumps

See issue #2800.
@hlinnaka hlinnaka force-pushed the collect-regression-test-core-dump branch from 6279c02 to 438d9e7 Compare September 24, 2024 21:04
Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's cool!

But not on arm64 test runs. I guess we have configured those runners differently?

cc @cicdteam regarding runners setup

Dockerfile.build-tools Outdated Show resolved Hide resolved
I hope this lets us capture backtraces in CI. At least it makes it
work on my laptop, which is valuable even if we need to do more for
CI.

See issue #2800.
So that compute_ctl can use it to print backtrace on core dumps

See issue #2800.
@hlinnaka hlinnaka force-pushed the collect-regression-test-core-dump branch from 438d9e7 to d9111d0 Compare September 27, 2024 07:29
@hlinnaka hlinnaka merged commit 357fa07 into main Sep 27, 2024
81 checks passed
hlinnaka added a commit that referenced this pull request Sep 27, 2024
I hope this lets us capture backtraces in CI. At least it makes it
work on my laptop, which is valuable even if we need to do more for
CI.

See issue #2800.
@hlinnaka hlinnaka deleted the collect-regression-test-core-dump branch September 27, 2024 12:36
bayandin pushed a commit that referenced this pull request Sep 29, 2024
I hope this lets us capture backtraces in CI. At least it makes it
work on my laptop, which is valuable even if we need to do more for
CI.

See issue #2800.
bayandin pushed a commit that referenced this pull request Sep 29, 2024
So that compute_ctl can use it to print backtrace on core dumps

See issue #2800.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capture and recovery of core dumps from regression tests
5 participants