Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: dedup if-err-then-call-on_key_error-and-set-ignore_key_with_err-and-continue logic #9123

Conversation

yliang412
Copy link
Contributor

@yliang412 yliang412 commented Sep 24, 2024

Problem

#8942 (comment)

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@yliang412
Copy link
Contributor Author

Dropping this.

@yliang412 yliang412 closed this Sep 24, 2024
@yliang412 yliang412 deleted the yuchen/dedupe-if-err-then-call-on_key_error-and-set-ignore_key_with_err-and-continue branch September 24, 2024 14:52
Copy link

4977 tests run: 4811 passed, 2 failed, 164 skipped (full report)


Failures on Postgres 17

Failures on Postgres 14

# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_lfc_resize[release-pg14] or test_pageserver_compaction_smoke[release-pg17]"
Flaky tests (1)

Postgres 14

Test coverage report is not available

The comment gets automatically updated with the latest test results
ee2c841 at 2024-09-24T15:04:11.415Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant