-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /installed_extensions endpoint to collect statistics about extension usage. #8917
Conversation
5120 tests run: 4913 passed, 0 failed, 207 skipped (full report)Flaky tests (3)Postgres 17
Postgres 16
Postgres 15
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
29f4e1a at 2024-10-09T11:32:00.283Z :recycle: |
0122201
to
e16d6f3
Compare
e16d6f3
to
5336ea5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a bunch of comments. My main concern is that as we deal a lot with third party code and formatting, we'd better handle all errors gracefully and only use expect/unwrap for stuff that 'should never happen' -- mutexes, runtimes, etc.
How is the new API endpoint going to be called? Who's going to call it and when? Did you consider exporting this information as a prometheus metric, instead? |
In my idea the caller will be cplane, similar to GetStartupMetrics.
Is it possible to add arbitrary hashmap as prometheus metric? I thought, it only supports prometheus metric types. |
6bd893f
to
6e2bc3a
Compare
2c51eef
to
7d79b2a
Compare
statistics about extension usage. It returns a list of installed extensions in the format: ```json { "extensions": [ { "extname": "extension_name", "versions": ["1.0", "1.1"], "n_databases": 5, } ] } ```
288049e
to
c81dd20
Compare
Co-authored-by: Heikki Linnakangas <[email protected]>
Add /installed_extensions endpoint to collect
statistics about extension usage.
It returns a list of installed extensions in the format: