Add archival_config endpoint to pageserver #8414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3126 tests run: 3005 passed, 0 failed, 121 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
f4a592b at 2024-07-19T16:52:06.217Z :recycle: |
arpad-m
force-pushed
the
arpad/tl-archive-1
branch
from
66f84d7
to
1c3451a
Compare
koivunej
approved these changes
Jul 19, 2024
skyzh
approved these changes
Jul 19, 2024
jcsp
reviewed
Jul 19, 2024
| Either archives or unarchives the given timeline. | ||
| An archived timeline may not have any non-archived children. | ||
| requestBody: | ||
| required: false |
There was a problem hiding this comment.
required: false - what would it mean to omit the body?
There was a problem hiding this comment.
This is from an earlier iteration where I made the param part of the url string. You are right, it is obligatory.
problame
pushed a commit
that referenced
this pull request
Jul 22, 2024
This adds an archival_config endpoint to the pageserver. Currently it has no effect, and always "works", but later the intent is that it will make a timeline archived/unarchived. - [x] add yml spec - [x] add endpoint handler Part of #8088
This was referenced Jul 22, 2024
arpad-m
added a commit
that referenced
this pull request
Jul 22, 2024
As pointed out in #8414 (comment) Part of #8088
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an archival_config endpoint to the pageserver. Currently it has no effect, and always "works", but later the intent is that it will make a timeline archived/unarchived.
Part of #8088