Skip to content

Commit

Permalink
NOAI (#9084)
Browse files Browse the repository at this point in the history
We can't FlushOneBuffer when we're in redo-only mode on PageServer, so
make execution of that function conditional on us not running in
pageserver walredo mode.
  • Loading branch information
MMeent authored Sep 23, 2024
1 parent 1c5d6e5 commit d865881
Show file tree
Hide file tree
Showing 7 changed files with 23 additions and 10 deletions.
1 change: 0 additions & 1 deletion .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1207,7 +1207,6 @@ jobs:
# Usually we do `needs: [...]`
needs:
- build-and-test-locally
- check-submodules
- check-codestyle-python
- check-codestyle-rust
- promote-images
Expand Down
16 changes: 15 additions & 1 deletion test_runner/regress/test_unlogged.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,13 @@ def test_unlogged(neon_simple_env: NeonEnv):
cur = conn.cursor()

cur.execute("CREATE UNLOGGED TABLE iut (id int);")
# create index to test unlogged index relation as well
# create index to test unlogged index relations as well
cur.execute("CREATE UNIQUE INDEX iut_idx ON iut (id);")
cur.execute("CREATE INDEX ON iut USING gist (int4range(id, id, '[]'));")
cur.execute("CREATE INDEX ON iut USING spgist (int4range(id, id, '[]'));")
cur.execute("CREATE INDEX ON iut USING gin ((id::text::jsonb));")
cur.execute("CREATE INDEX ON iut USING brin (id);")
cur.execute("CREATE INDEX ON iut USING hash (id);")
cur.execute("ALTER TABLE iut ADD COLUMN seq int GENERATED ALWAYS AS IDENTITY;")
cur.execute("INSERT INTO iut (id) values (42);")

Expand All @@ -39,3 +44,12 @@ def test_unlogged(neon_simple_env: NeonEnv):
assert results == [(43, 2)]
else:
assert results == [(43, 1)]

# Flush all data and compact it, so we detect any errors related to
# unlogged indexes materialization.
ps_http = env.pageserver.http_client()
ps_http.timeline_compact(
tenant_id=env.initial_tenant,
timeline_id=env.initial_timeline,
force_image_layer_creation=True,
)
2 changes: 1 addition & 1 deletion vendor/postgres-v14
2 changes: 1 addition & 1 deletion vendor/postgres-v15
2 changes: 1 addition & 1 deletion vendor/postgres-v16
2 changes: 1 addition & 1 deletion vendor/postgres-v17
8 changes: 4 additions & 4 deletions vendor/revisions.json
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
{
"v17": [
"17rc1",
"2cf120e7393ca5f537c6a38b457585576dc035fc"
"7b3e52c75ca384de9c69477c158b1f5dcdcbb4be"
],
"v16": [
"16.4",
"1d7081a3b076ddf5086e0b118d4329820e6a7427"
"e131a9c027b202ce92bd7b9cf2569d48a6f9948e"
],
"v15": [
"15.8",
"16c3c6b64f1420a367a2a9b2510f20d94f791af8"
"22e580fe9ffcea7e02592110b1c9bf426d83cada"
],
"v14": [
"14.13",
"a38d15f3233a4c07f2bf3335fcbd874dd1f4e386"
"2199b83fb72680001ce0f43bf6187a21dfb8f45d"
]
}

1 comment on commit d865881

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5074 tests run: 4900 passed, 0 failed, 174 skipped (full report)


Flaky tests (1)

Postgres 16

Code coverage* (full report)

  • functions: 32.1% (7455 of 23225 functions)
  • lines: 49.9% (60101 of 120333 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d865881 at 2024-09-24T01:26:49.608Z :recycle:

Please sign in to comment.