Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: contract filter is now editable #824

Merged
merged 4 commits into from
Jun 24, 2024
Merged

fix: contract filter is now editable #824

merged 4 commits into from
Jun 24, 2024

Conversation

Kevin101Zhang
Copy link
Contributor

@Kevin101Zhang Kevin101Zhang commented Jun 20, 2024 •
edited
Loading

Fixed logic to handle editable contract filter

@Kevin101Zhang Kevin101Zhang linked an issue Jun 20, 2024 that may be closed by this pull request
Contract Filter is uneditable #819
Closed
@Kevin101Zhang
Copy link
Contributor Author

I swapped the logic here on accident during a refactor.
This was the original form logic.

queryapi/frontend/src/components/Form/IndexerConfigOptionsInputGroup.jsx

Line 127 in ffceeef

value={startBlock === START_BLOCK.CONTINUE ? indexerDetails.rule.affected_account_id : contractFilter}

@Kevin101Zhang Kevin101Zhang marked this pull request as ready for review June 21, 2024 00:00
@Kevin101Zhang Kevin101Zhang requested a review from a team as a code owner June 21, 2024 00:00
@Kevin101Zhang Kevin101Zhang merged commit 5185457 into main Jun 24, 2024
4 checks passed
@Kevin101Zhang Kevin101Zhang deleted the 819-contract-filter-is-uneditable branch June 24, 2024 17:32
@morgsmccauley morgsmccauley mentioned this pull request Jun 24, 2024
Merged
@morgsmccauley morgsmccauley mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contract Filter is uneditable
1 participant
@Kevin101Zhang