Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Prevent registration of new accounts/indexers #1018

Closed
wants to merge 1 commit into from

Conversation

morgsmccauley
Copy link
Collaborator

This PR updates the registry contract to prevent registration of new Accounts and also new Indexer Functions under existing accounts. Most of the changes are making the tests work due to registration now being prevented.

@morgsmccauley morgsmccauley requested a review from a team as a code owner August 22, 2024 02:50
@morgsmccauley morgsmccauley linked an issue Aug 22, 2024 that may be closed by this pull request
Copy link
Collaborator

@darunrs darunrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're preventing registration of new accounts, should we also disable the add_user function too or just ignore it?

@gabehamilton
Copy link
Collaborator

Maybe we should check in the previous version of this file as the contract template? In case anyone wants to spin QueryApi up.

@morgsmccauley
Copy link
Collaborator Author

Since we're preventing registration of new accounts, should we also disable the add_user function too or just ignore it?

@darunrs Users are kind of meaningless at this point - I'll ignore for now.

Maybe we should check in the previous version of this file as the contract template? In case anyone wants to spin QueryApi up.

@gabehamilton good point - I'll deploy this change but not merge.

@morgsmccauley
Copy link
Collaborator Author

Deployed to:
dev-queryapi.dataplatform.near
queryapi.dataplatform.near

@morgsmccauley morgsmccauley deleted the feat/prevent-registration branch August 27, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent creation of new indexers
3 participants