Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: inline get_epoch_minted_amount in epoch manager #12435

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stedfn
Copy link
Contributor

@stedfn stedfn commented Nov 11, 2024

This PR inlines the usage of get_epoch_minted_amount and removes its definition as it is only used in 2 places

@stedfn stedfn self-assigned this Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.46%. Comparing base (c10b078) to head (14aa7bd).

Files with missing lines Patch % Lines
chain/chain/src/chain.rs 0.00% 0 Missing and 1 partial ⚠️
chain/client/src/client.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12435      +/-   ##
==========================================
- Coverage   71.47%   71.46%   -0.02%     
==========================================
  Files         837      837              
  Lines      169397   169390       -7     
  Branches   169397   169390       -7     
==========================================
- Hits       121076   121047      -29     
- Misses      42976    42991      +15     
- Partials     5345     5352       +7     
Flag Coverage Δ
backward-compatibility 0.16% <0.00%> (+<0.01%) ⬆️
db-migration 0.16% <0.00%> (+<0.01%) ⬆️
genesis-check 1.28% <0.00%> (+<0.01%) ⬆️
integration-tests 39.35% <0.00%> (-0.01%) ⬇️
linux 70.78% <0.00%> (+<0.01%) ⬆️
linux-nightly 71.03% <0.00%> (-0.01%) ⬇️
macos 51.04% <0.00%> (-0.01%) ⬇️
pytests 1.59% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.40% <0.00%> (+<0.01%) ⬆️
unittests 64.01% <0.00%> (-0.01%) ⬇️
upgradability 0.21% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stedfn stedfn requested a review from pugachAG November 14, 2024 21:40
@stedfn stedfn marked this pull request as ready for review November 14, 2024 21:40
@stedfn stedfn requested a review from a team as a code owner November 14, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant