Implement improvements as suggested in the last report #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚨Attention: before merging, this patch needs to be squashed with a future commit which changes where we fetch wasi-sdk binaries, now we need to fetch from a near fork of wasi-sdk. This patch includes improvements as suggested in the last report. Most notably, it drops a very legacy version of wasi-sdk and is able to make use of latest wasi-sdk. The wasi-sdk patch makes things work out of the box for the near platform, allowing the wasi-stub hack to be dropped here as well, so no need to maintain a binaryen fork either.
ailisp
reviewed
Aug 1, 2023
| } -Wl,--lto-O3 -o ${contractTarget}`, | ||
| `${CC} -mcpu=mvp -Oz -fno-strict-aliasing ${DEFS} ${INCLUDES} ${SOURCES} ${LIBS} -mexec-model=reactor -Wl,--allow-undefined -Wl,--stack-first,-z,stack-size=${ | ||
| 256 * 1024 * 2 | ||
| } -Wl,--compress-relocations,--strip-debug -o ${contractTarget}`, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨Attention: before merging, this patch needs to be squashed with a future commit which changes where we fetch wasi-sdk binaries, now we need to fetch from a near fork of wasi-sdk.
This patch includes improvements as suggested in the last report. Most notably, it drops a very legacy version of wasi-sdk and is able to make use of latest wasi-sdk. The wasi-sdk patch makes things work out of the box for the near platform, allowing the wasi-stub hack to be dropped here as well, so no need to maintain a binaryen fork either.
Pre-flight checklist
Motivation
Test Plan
Related issues/PRs