Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replacing atty unmaintained dependency #194

Merged
merged 2 commits into from
Aug 6, 2024
Merged

fix: Replacing atty unmaintained dependency #194

merged 2 commits into from
Aug 6, 2024

Conversation

MPSxDev
Copy link
Contributor

@MPSxDev MPSxDev commented Aug 6, 2024

Atty is replaced by std::io::IsTerminal

Because atty has been unmaintained for 4 years, it is necessary to update it in this case to std::io::IsTerminal, which is part of the Rust Standard Library. Ref

Changes:

  • File: cargo-near\src\commands\build_command\docker.rs
    Description: Atty is replaced by std::io::IsTerminal

  • File: cargo-near\src\common.rs
    Description: Atty is replaced by std::io::IsTerminal

  • File: cargo-near\cargo-near\src\main.rs
    Description: Atty is replaced by std::io::IsTerminal

  • File: cargo-near\Cargo.toml
    Description: Atty is removed and env_logger is updated to 0.11.5 because the previous version used atty.

  • File: cargo-near\integration-tests\Cargo.toml
    Description: env_logger is updated to 0.11.5 because the previous version used atty.

Reference issue: Potentially replace unmaintained libraries ignored

MPSxDev and others added 2 commits August 6, 2024 11:28
-atty, a dependency that has not been maintained for 4 years, is replaced by the standard library std::io::IsTerminal
-env_logger is updated to version 0.11.5, which does not include atty
Copy link
Contributor

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MPSxDev Thanks for the contribution! Let's keep it going. I will release a new version of cargo-near shortly after this PR is merged

@race-of-sloths invite

@race-of-sloths
Copy link

@frol Thank you for calling!

@MPSxDev Thank you for the contribution! Join Race of Sloths by simply mentioning me in your comment/PRs description and start collecting Sloth Points through contributions to open source projects.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@frol frol enabled auto-merge (squash) August 6, 2024 16:38
@frol frol merged commit 95013b8 into near:main Aug 6, 2024
14 checks passed
@frol frol mentioned this pull request Jul 30, 2024
frol added a commit that referenced this pull request Aug 6, 2024
## 🤖 New release
* `cargo-near`: 0.6.4 -> 0.7.0

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.7.0](cargo-near-v0.6.4...cargo-near-v0.7.0)
- 2024-08-06

### Added
- Added ability to use SourceScan
([#134](#134))

### Fixed
- Replacing atty unmaintained dependency
([#194](#194))

### Other
- update default docker images tags + digests
([#191](#191))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants