Fixed websocket path #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow path to be passed into websocket connection so that if there is a proxy in between it can be setup with a path on the proxy server even though it doesn't matter for the server connection. Also there is a future option we can introduce to pass HTTP headers in case application might use them to authenticate with the proxy for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow path to be passed into websocket connection so that if there is a proxy in between it can be setup with a path on the proxy server even though it doesn't matter for the server connection.
Also there is a future option we can introduce to pass HTTP headers in case application might use them to authenticate with the proxy for example.
Note: this feature was already present in the original websocket-kit code and I chose to simplify it at the time.