Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make timeout an optional param in KeyWatcher.updates #622

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevinhikaruevans
Copy link

@kevinhikaruevans kevinhikaruevans commented Oct 16, 2024

Since asyncio.wait_for accepts None to indicate no timeout, it'd be helpful to also accept None here. Since the default value is 5.0 seconds, the typehint infers/defaults to type float instead of float | None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant