[FIXED] SEGFAULT in js_Subscribe if consumer Name is NULL #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovic
reviewed
Nov 16, 2023
| @@ -2656,7 +2656,10 @@ _subscribe(natsSubscription **new_sub, jsCtx *js, const char *subject, const cha | |||
| // set only if jsi->consumer is NULL! | |||
| if (jsi->consumer == NULL) | |||
| { | |||
| DUP_STRING(s, jsi->consumer, info->Name); | |||
| if (info->Name != NULL) | |||
There was a problem hiding this comment.
But why name would be NULL? It should be set no? I am not sure if just doing that here does not move the problem to some other place.
| if (info->Name != NULL) | ||
| { | ||
| DUP_STRING(s, jsi->consumer, info->Name); | ||
| } | ||
| if (s == NATS_OK) |
There was a problem hiding this comment.
Not related to this PR, but I wonder if I should not have done the rest of that code for pull consumers only...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #695